✅ improve sh mocking reliability#2980
Merged
Merged
Conversation
AndreMiras
force-pushed
the
feature/improve_sh_mocking
branch
from
11ff44d to
0e3b21e
Compare
Make sure the mocking also works on setup without cmake or make. Build dependencies should not be required to run uni tests. The error was: ``` AttributeError: <module 'sh' from 'venv/lib/python3.11/site-packages/sh.py'> does not have the attribute 'cmake' ```
AndreMiras
force-pushed
the
feature/improve_sh_mocking
branch
from
0e3b21e to
9ef3f9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the mocking also works on setup without cmake or make. Build dependencies should not be required to run uni tests. The error was: